Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip repository_registry out of tool shed 2.0 #18647

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

jmchilton
Copy link
Member

We don't need any of this for the new UI and only used one small thing for the API that I have just replaced with a live database query. Should dramatically speed up the tool shed startup and reduce the complexity of repository operations at runtime.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

It seems like it is only used by repository_grids - which I think are unused by the new tool shed. I don't recall writing any client side grid framework code and my PR description did claim it was mako free.
@jmchilton jmchilton marked this pull request as ready for review August 5, 2024 20:27
@github-actions github-actions bot added this to the 24.2 milestone Aug 5, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Aug 6, 2024

Fantastic, this results in almost immediate restarts! Still running into

Target tool expected at [/srv/toolshed/test/var/tmp/tmp-toolshed-tool_source3d7h1c07/../../../../../../toolshed-repos/test/001/repo_1841/deseq2.xml] and not found, inconsistent repository state or application configuration

though.

@mvdbeek
Copy link
Member

mvdbeek commented Aug 6, 2024

Still running into

This is fixed by a repository metadata reset

@mvdbeek mvdbeek merged commit d1e0607 into galaxyproject:dev Aug 6, 2024
52 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants